pecos / tps

Torch Plasma Simulator
BSD 3-Clause "New" or "Revised" License
8 stars 2 forks source link

Make sure CI on local runners cleans up #254

Open trevilo opened 7 months ago

trevilo commented 7 months ago

We have observed some recent build failures (e.g., here on PR #251) that appear to be due to a failure of the CI scripts to clean up after themselves. Specifically, the offending build gave the following link error:

/usr/bin/ld: ./.libs/libtps.so: undefined reference to `GaussianInterpExtData::GaussianInterpExtData(mfem::ParMesh*, LoMachOptions*, TPS::Tps*)'

which is nonsensical b/c the GaussianInterExtData class was not introduced until PR #253.

But, these PRs did kick of the automated CI on marvin in such a way that if the CI from PR #253 ran and didn't clean up sufficiently well, a stale object from that build could have caused a problem for the next CI run on PR #251.

So, that is the current hypothesis. If correct, the fix is to make sure each build cleans up after itself.