search

pecos / tps

Torch Plasma Simulator
BSD 3-Clause "New" or "Revised" License
8 stars 2 forks source link

initial refactor of input parsing #88

Closed koomie closed 2 years ago

koomie commented 2 years ago

in support of #87. Updates minimum version requirement for libGRVY.

trevilo commented 2 years ago

Looks pretty good to me @koomie. Two names in the file that I wouldn't mind changing:

Only other question: I can't find where the viscousSource options are read in M2ulPhyS::parseSolverOptions2(). Is that an oversight or is it read somewhere else?

marc-85 commented 2 years ago

I agree with Todd and maybe 'iterFreq' could be something like 'outputFreq', 'dumpFreq' or something like that?

koomie commented 2 years ago

Looks pretty good to me @koomie. Two names in the file that I wouldn't mind changing:

  • flow/equations : maybe flow/equation_system instead?
  • viscousSource: this houses the options to set the spatially dependent viscosity multiplier, correct? I wouldn't have guessed that based on the name. Maybe ` or something similar?

Only other question: I can't find where the viscousSource options are read in M2ulPhyS::parseSolverOptions2(). Is that an oversight or is it read somewhere else?

Probably an oversight and indication it is not used in any current regression tests. I can update to viscosityMultiplierFunction and update the parsing routine.

koomie commented 2 years ago

I agree with Todd and maybe 'iterFreq' could be something like 'outputFreq', 'dumpFreq' or something like that?

I like outputFreq so I'll update that name as well.

koomie commented 2 years ago

Updated input names based on feedback: