pedal-edu / pedal

A collection of tools to analyze student's Python source code
https://pedal-edu.github.io/pedal/
MIT License
29 stars 7 forks source link

System Arguments #112

Open lukesg08 opened 1 year ago

lukesg08 commented 1 year ago

I think we have somewhere in the documentation that we do not handle system arguments. This should be added to our list of things to deal with.

acbart commented 8 months ago

Would this be sys.args? So you'd want to be able to provide a sys.args value conveniently? Because I think you can use the existing infrastructure to achieve this, but it's not as convenient as it could be. You'd need to provide some information to TIFA, and also add the data to the sandbox. But it would be pretty easy to provide some easy convenience functions to make that happen. I think there's some work per environment to do too, to make sure the data gets passed in conveniently.

lukesg08 commented 8 months ago

Yes, this would be sys.args. I'd expect this would actually be something in the run function from the sandbox for Pedal, but I didn't see an option for that in the teacher reference.

acbart commented 7 months ago

Conversation at SIGCSE is that likely we should put this on run and make it easy for the instructors to specify. Also probably provide a set_sys_args similar to how we do that for set_input.

acbart commented 1 month ago

Not sure where this left off, but I notice in the current version it seems like sys args leaks into the students' code execution. We should make sure that this is more tightly controlled!