search

pediapress / mwlib

mediawiki parser library
103 stars 35 forks source link

mwlib should pass cookies for authentication for login-required wikis #60

Open hexmode opened 8 years ago

hexmode commented 8 years ago

As per subject. See https://phabricator.wikimedia.org/T142924 and the related code.

That hack wouldn't be necessary if there were a way that mwlib could pass cookies the way that parsoid does.

ckepper commented 8 years ago

Hi Mark,

this is Christoph from PediaPress. Our team has changed quite a bit and I am not sure if I am able to fix this issue. What should I do?

Christoph

Am 16.08.2016 um 09:26 schrieb Mark A. Hershberger notifications@github.com:

As per subject. See https://phabricator.wikimedia.org/T142924 and the related code.

That hack wouldn't be necessary if there were a way that mwlib could pass cookies the way that parsoid does.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Christoph Kepper

PediaPress GmbH Moritz-Hilf-Str. 26 65549 Limburg

Phone: +49 (0)6131 3271809 http://pediapress.com

hexmode commented 8 years ago

To fix this, you would need the process that MediaWiki talks to to store the cookies that MediaWiki sends so that when mwlib talks to MediaWiki, it can pass them back in.

On the MediaWiki side, MW needs to pass the cookies it gets from the user in its requests to mwlib. An example can be see in VisualEditor's code

ckepper commented 8 years ago

Sorry for the delay. Can you give an example of a wiki that is affected by this bug? It would be helpful for debugging/testing.