search

pedro-otero / crews-be

Find credits of the song you're playing in Spotify from Discogs
1 stars 0 forks source link

Duplicate credits #3

Closed pedro-otero closed 6 years ago

pedro-otero commented 6 years ago
Album Id Track Id
Body Talk 1 7J4oxoeFQLTrHnjNu2ZaJ5 Fembot 6agCYmY7mHdd2HtzkKR0uU

Klas Åhlund, Patrik Berger and Robyn appear as composers twice. This can't be related to the issue with accented names (the one fixed with b37985023db356db685c0f256de629dc2189b25b) since only Klas' is.

The issue likely has to do with the fact that composers are associated using different ways to refer to it that Discogs has mapped in roles. So the problem can be this guy.

pedro-otero commented 6 years ago

https://github.com/pedro-otero/crews-be/pull/4 fixes it but this approach implies that useless data will still be kept in the state and will just be filtered when requested. Maybe the credits reducer should address this issue.