search

pedro-w / vscode-tmlanguage

Syntax highlighting for TextMate/SublimeText language definitions
MIT License
18 stars 4 forks source link

Publish vscode-tmlanguage in Marketplace #3

Closed texastoland closed 2 years ago

texastoland commented 2 years ago

The upstream repo is archived. Would you mind publishing your fixes? And either merging Togusa09/vscode-tmlanguage#28 or making it configurable? I appreciate what you've done!

pedro-w commented 2 years ago

Thanks, I've transferred this to the correct repository!

texastoland commented 2 years ago

I've been using your last version for a few days already 🙏🏼 Everything working smoothly. There are a couple highlighting bugs in YAML related to comments. I'll open a separate issue and happy to fix it myself.

pedro-w commented 2 years ago

Sorry for the delay. I was merging https://github.com/Togusa09/vscode-tmlanguage/pull/28 but it doesn't work quite right; specifically when you convert a file it strips the extension and adds the new one, but a file like something.tmlanguage.json has two extensions so you end up with a converted file like something.tmlanguage.tmlanguage.yaml. (this was OK before because the extension was .JSON-tmlanguage - that's one extension) I know how to fix it, but if someone else wants they can jump in.

texastoland commented 2 years ago

I'll PR in the next couple days 👌🏼

pedro-w commented 2 years ago

I have published it now as v0.11.0 and hopefully we can follow up before long with a version including the change to the extensions.

texastoland commented 2 years ago

You can add https://marketplace.visualstudio.com/items?itemName=pedro-w.tmlanguage to the GitHub page! I tweeted it too 🍾 Sorry I came down ill for a few days in the middle of a frustrating TextMate bug. I haven't forgotten 🤞🏼

ghost commented 2 years ago

Is Togusa09#28 live in ths repository?

pedro-w commented 2 years ago

Not yet because texastoland has been ill and not able to fix it (there are some problems with https://github.com/Togusa09/vscode-tmlanguage/pull/28 as it is currently).

texastoland commented 2 years ago

I finally finished my other PR. I'll see how far I get this weekend 🤞🏼

pedro-w commented 2 years ago

OK, I've made a new branch containing (most of) https://github.com/Togusa09/vscode-tmlanguage/pull/28 - unfortunately @SNDST00M deleted the source repo so I had to redo it by hand. It's in https://github.com/pedro-w/vscode-tmlanguage/tree/file-extensions for the moment.

ghost commented 2 years ago

I do believe adding .patch to URL and using git apply works better.