search

pedroSG94 / RootEncoder

RootEncoder for Android (rtmp-rtsp-stream-client-java) is a stream encoder to push video/audio to media servers using protocols RTMP, RTSP, SRT and UDP with all code written in Java/Kotlin
Apache License 2.0
2.57k stars 776 forks source link

Passing the '/' symbol in the URL will result in an exception #1566

Closed Moyout closed 2 months ago

Moyout commented 2 months ago

When my RTMP link is like this：

rtmp://192.168.238.182:1935/live/100044?userId=100044&roomTitle=123123&roomCover=http://192.168.238.182/xxxx.png

when connecting, the console output is as follows:

send Command(name='connect', transactionId=1, timeStamp=0, streamId=0, data=[AmfString value: connect, AmfNumber value: 1.0, AmfObject properties: {AmfString value: app=AmfString value: live/100044?userId=100044&roomTitle=123123&roomCover=http:, AmfString value: flashVer=AmfString value: FMLE/3.0 (compatible; Lavf57.56.101), AmfString value: tcUrl=AmfString value: rtmp://192.168.238.182:1935/live/100044?userId=100044&roomTitle=123123&roomCover=http:, AmfString value: objectEncoding=AmfNumber value: 0.0}], bodySize=259)

My roomCover parameter has been truncated. How can I pass parameters with a '/' symbol ?

pedroSG94 commented 2 months ago

Hello,

This seems a parse error in the library. I'm already working to fix it. Thank you for the report

Moyout commented 2 months ago

你好，

这似乎是库中的解析错误。 我已经在努力修复它。感谢您的报告

Hello,

This seems a parse error in the library. I'm already working to fix it. Thank you for the report

Okay, if it's fixed, you can reply to me

pedroSG94 commented 2 months ago

Hello,

I did a fix for this case: https://github.com/pedroSG94/RootEncoder/pull/1567

I'm doing more testing because this change is important since I removed the previous parser.

Moyout commented 2 months ago

okay

你好，

我对此情况进行了修复： #1567

我发起了更多的测试，因为自从我删除了以前的解析器后，这个改变就很重要。

pedroSG94 commented 2 months ago

The fix is available in master now. I did a gradle compilation for it meanwhile release 2.5.1 is available:

  implementation 'com.github.pedroSG94.RootEncoder:library:591f882147'
Moyout commented 2 months ago

That's great

The fix is available in master now. I did a gradle compilation for it meanwhile release 2.5.1 is available:

  implementation 'com.github.pedroSG94.RootEncoder:library:591f882147'