pedroabreu / ion-gallery

Ionic gallery directive
MIT License
124 stars 61 forks source link

Feature Request - Show full images on click within slideshow #17

Closed w3development-kn closed 8 years ago

w3development-kn commented 8 years ago

My webservice returns about 100 images as thumbnails with 100x100px. It would be awesome if the original pictures (links returned from the webservice, too) would open on click within the slideshow.

The new data would look like this:

$scope.items = [ { src:'http://www.wired.com/images_blogs/rawfile/2013/11/offset_WaterHouseMarineImages_62652-2-660x440.jpg', fullSrc: "http://www.fullimage.de/image.jpg", sub: 'This is a subtitle' }.....

pedroabreu commented 8 years ago

Interesting. So the feature would be opening a "different" image (source) wise. This can be useful for videos, for example, where you load a thumbnail and then open up the video on click. Should be fairly simple to implement.

w3development-kn commented 8 years ago

Any chance for this to come in a few days? ;)

pedroabreu commented 8 years ago

I've made a PR with this change, by adding the thumbnail property. I will have a think if it makes sense as it is and probably merge it tonight.

Have a look at it as well.

w3development-kn commented 8 years ago

Great thank you. Another short question. I´m doing changes to src/templates/gallery.html. But they get not affected in my app. Any ideas why?

pedroabreu commented 8 years ago

you need to compile it with gulp (just run 'gulp' on the plugin folder). I assume you're just loading the JS and CSS files in your project, the html is inject in the JS using angular-templatecache. I'm thinking of a way of allowing custom templates but struggling a bit with it

pedroabreu commented 8 years ago

Merged