search

pedroabreu / ion-gallery

Ionic gallery directive
MIT License
124 stars 61 forks source link

Avoid calling remove when _modal isn't defined. #29

Closed ggoforth closed 8 years ago

ggoforth commented 8 years ago

Not sure if this is the best way to handle this, or if it's possible to not enable this scope in the first place when you haven't clicked on an image. Thoughts? Thanks for your work!!!

ggoforth commented 8 years ago

Ugh, just realized this should be built before merging. Will add that shortly.

pedroabreu commented 8 years ago

I just realized that I made a mistake on the last commit. For some reason, I wasn't working on a recent version of the plugin.

If you check the history of the slider.js, that call was wrapped in a try catch. I'll revert back the commit on that part.

ggoforth commented 8 years ago

Awesome, I did catch that after I submitted my PR. Will update once that commit is back in. Thanks!