search

pedroabreu / ion-gallery

Ionic gallery directive
MIT License
124 stars 61 forks source link

Add config option to allow fixed row size #36

Closed pedroabreu closed 8 years ago

pedroabreu commented 8 years ago

Stupid me can't seem to update the same PR so I have to open a new one.

As for the changes, I think it makes more sense this way, moving the flag validation to the service. I think this way it covers both situations.

And the flag was set to true by default

troyshu commented 8 years ago

Just some minor points about how "getRowSize" works, sorry about editing the dist file and not the src files before :)

pedroabreu commented 8 years ago

Don't worry about it. I should probably add a section on the readme for that, so anyone can edit and rebuild the dist files

pedroabreu commented 8 years ago

I've pushed some fixes. From the tests I've made it seems to be working fine although it's really not making any sense to me the dynamic row size... I think the issue is that I didn't think at the beginning of adding pictures dynamically (very dumb move). Logic is a bit messy, will need some refactoring but I'll leave it for another PR