search

pedroabreu / ion-gallery

Ionic gallery directive
MIT License
124 stars 61 forks source link

ion-gallery ver 0.1.13 not popping gallery #48

Closed ofershap closed 8 years ago

ofershap commented 8 years ago

after updating to latest version, tapping on image didnt open the gallery view. investigating the bug found out that this code inside gallery.html doesn't work properly: ng-click="customCallback ? ionItemCallback({item: photo}) : showImage({{photo.position}})">

i havn't configure no callback, just added a simple directive to my code:

but "showImage" doesn't fire when i tap.
replacing it back to the old "ng-click="showImage({{photo.position}})" solved the issue. ofcourse i had to compile the gulp afterward, or just update the minified script at the end of gallery.js too in order for it to work.

FYI if someone having troubles with that. @pedroabreu please fix that flaw.. thanks.

pedroabreu commented 8 years ago

I noticed that I have the same issue now... Don't think I had it when I did the merge but anyway I think the issue is here https://github.com/angular/angular.js/issues/6404

The ionCallback is always evaluated as true even if the function is not passed to the directive. It seems that this is fixed on angular 1.4 so it's an issue for 1.3. I'm implementing now a workaround to check if the function is passed or not

pedroabreu commented 8 years ago

Fixed with PR #52