search

pedroabreu / ion-gallery

Ionic gallery directive
MIT License
124 stars 61 forks source link

Make label(s) configurable #9

Closed hypery2k closed 9 years ago

pedroabreu commented 9 years ago

Would it make sense to move more stuff to the provider ? Like the nr of images in the row or if subtitles are on/off ?

hypery2k commented 9 years ago

seems like a good idea. Maybe it should still be possible to override the global config per directive parameter

pedroabreu commented 9 years ago

I'll grab this PR and make it in a way where you can set the settings from the provider or as a parameter in the element. Where the provider will take priority over it

hypery2k commented 9 years ago

cool, sounds great. Thanks

pedroabreu commented 9 years ago

Can you do a rebase of this so it can be merged ? Sorry if this isn't how it's supposed to be (the push to this PR) but it seemed the logical way to do it