search

pedrocr / imagepipe

Image processing pipeline
GNU Lesser General Public License v3.0
44 stars 15 forks source link

Changed output of converter to JPEG #8

Closed schoenenberg closed 4 years ago

schoenenberg commented 4 years ago

Hi Pedro,

great work developing a whole image pipeline from scratch in rust !!

I have changed the converter executable to export the raw image in JPEG-Format using functions from the image crate. I think it's the more common format and will make the converter-executable more usable to other users.

If you like this you can merge this, if not maybe consider it as an example for other users.

Best regards, Maximilian

pedrocr commented 4 years ago

This looks great to me. The image dependency is already there and might as well output jpeg. Could you fix the merge conflict please?

If you're interested in this you may like chimper as well:

https://github.com/pedrocr/chimper

I haven't had time to work on it but it's my take on a 100% rust photography workflow. It already exposes a lot of imagepipe as interactive. It's only missing a few other interface tweaks and an export button to be useful.

pedrocr commented 4 years ago

Thanks. It's best to rebase on current master instead of adding merge commits to a PR.

pedrocr commented 4 years ago

Merged manually. Thanks!

schoenenberg commented 4 years ago

Thanks, I had some problems fix it..