search

pedrocr / rawloader

rust library to extract the raw data and some metadata from digital camera images
GNU Lesser General Public License v2.1
304 stars 53 forks source link

replace enum_primitive with enum-repr #22

Closed paolobarbolini closed 4 years ago

paolobarbolini commented 4 years ago

In an effort to reduce duplicate crate versions in projects, replace the unmaintained enum_primitive crate which depends on an old version of num-traits with enum-repr.

pedrocr commented 4 years ago

Have you by any chance benchmarked this? This is something that is in the fast path so I worry a bit about this.

The PR doesn't merge now, because of the 2018 edition changes. Could you please fix that?

paolobarbolini commented 4 years ago

I did a quick benchmark comparing the old implementation with the new one and enum-repr seems to be about the same as enum-primitive