Open schoenenberg opened 4 years ago
There are a few rustc warnings now that should definitely be fixed. I don't know what kinds of things clippy suggests be changed but I assume those are fine too.
One thing I haven't done yet that would be useful for those kinds of refactorings is getting an automated regression testing setup by making sure the output stays exactly the same over the test set in https://raw.pixls.us/
. But feel free to suggest some changes. I'll review them manually if needed.
Regression tests would be great for a library like this. I found this library and will check it out: retest
My plan for this was actually quite simple:
Since doing the raw processing without the image pipeline is very fast, it should be a pretty fast test run that can be used on every PR/commit. The only problem is that it requires having quite a few GB of test images locally. I don't know if that means I can't do that test in travis for automation and need to set it up in my own server and integrate with GitHub.
I will definitely do this before I create a PR for the Clippy-Warnings. I'm just really busy right now. That's why it may take a while.
Hi Pedro,
I would like to fix some
clippy
-warnings in the code, if this is ok for you.Best regards, Maximilian