pedrofgd / api-rest-broker

Projeto TCC Mack para avaliação de uma proposta de Broker para garantir alta disponibilidade no consumo de recursos externos via API REST
1 stars 0 forks source link

Escrita de logs no InfluxDB de forma assíncrona #72

Closed pedrofgd closed 1 year ago

pedrofgd commented 1 year ago

Esse ajuste na escrita no InfluxDB já resolveu todos os erros do teste de carga.

Os demais ajustes (próximos PRs) serão para melhorar o tempo de execução, que agora está na casa de 2 segundos.

Captura de Tela 2023-05-16 às 13 02 14
pedrofgd commented 1 year ago

@An-225 na verdade os resultados já estão no nível aceitável...

Naquele último print, com 2s de média por request, eu que estava executando a aplicação em modo Debug

Executando no profile, já deu para ver os resultados reais:

Captura de Tela 2023-05-16 às 13 27 22 Captura de Tela 2023-05-16 às 13 27 09



E a comparação entre o tempo de resposta do provedor com o tempo de processamento do Broker está ficando assim:

Captura de Tela 2023-05-16 às 13 52 36
gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [6665779](https://dashboard.gitguardian.com/incidents/6665779?occurrence=94980221) | Generic High Entropy Secret | bf0e28997d21013f02de3bbbfcf788cb11bd1837 | pocs/v2/ApiBroker/src/ApiBroker.API/appsettings.Development.json | [View secret](https://github.com/pedrofgd/tcc-mack/commit/bf0e28997d21013f02de3bbbfcf788cb11bd1837#diff-7735a7c7d1718f274d991309845832ccb9670f3e09b7a632c6217fa64a76f3fbL4) | | [6686459](https://dashboard.gitguardian.com/incidents/6686459?occurrence=94980220) | Generic High Entropy Secret | bf0e28997d21013f02de3bbbfcf788cb11bd1837 | pocs/v2/ApiBroker/src/ApiBroker.API/appsettings.Development.json | [View secret](https://github.com/pedrofgd/tcc-mack/commit/bf0e28997d21013f02de3bbbfcf788cb11bd1837#diff-7735a7c7d1718f274d991309845832ccb9670f3e09b7a632c6217fa64a76f3fbR4) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

pedrofgd commented 1 year ago

Aeewww, já da pra mostrar pra prof!

@An-225 tem mais um pequeno problema, que vai afetar um pouco a performance... está na #73 Mas acho que não é impeditivo para executar os testes para colocar no artigo que vamos enviar dia 19.

Podemos corrigir esse problema semana que vem, para tentar colocar nos testes do artigo final