search

pedrofurtado / qrcode_pix_ruby

Ruby gem for QRCode generation of Pix (Pagamento Instantรขneo Brasileiro - Banco Central do Brasil)
https://rubygems.org/gems/qrcode_pix_ruby
MIT License
43 stars 7 forks source link

Refactor code that set values to pix object in config.ru file #12

Closed marciojg closed 3 years ago

marciojg commented 3 years ago

@pedrofurtado I did not understand how can test the method generate_html_with(env) ๐Ÿ˜… What the format of param env? And How I can test rake locally? Can help me with this? ๐Ÿ™ƒ

But, deducing that the method params returns a hash I created the PR ๐Ÿ˜‡

codecov-commenter commented 3 years ago

Codecov Report

Merging #12 (138127c) into master (77c5e0f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          205       205           
=========================================
  Hits           205       205

Continue to review full report at Codecov.

Legend - Click here to learn more ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data Powered by Codecov. Last update 77c5e0f...138127c. Read the comment docs.

marciojg commented 3 years ago

@pedrofurtado Finally, I could send the commit :)

Tks by de Dockerfile on the demo. It was very useful.