pedrofurtado / qrcode_pix_ruby

Ruby gem for QRCode generation of Pix (Pagamento Instantâneo Brasileiro - Banco Central do Brasil)
https://rubygems.org/gems/qrcode_pix_ruby
MIT License
43 stars 7 forks source link

Fix CRC16 on payload #30

Closed odairbr closed 1 year ago

odairbr commented 1 year ago

Durante alguns teste pegamos um caso em que payload terminou com 3 dígitos, AA8, no CRC e por isso é inválido o correto seira com 4 dígitos 0AA8

Ajustes

Ps: ficou igual que o @everestcw havia feito

mergeable[bot] commented 1 year ago

Thanks for creating a pull request! A maintainer will review your changes shortly.

codecov-commenter commented 1 year ago

Codecov Report

Merging #30 (53a7644) into master (143c21c) will not change coverage. The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##            master       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          209       214    +5     
=========================================
+ Hits           209       214    +5     
Impacted Files Coverage Δ
lib/qrcode_pix_ruby/payload.rb 100.00% <100.00%> (ø)
spec/qrcode_pix_ruby_spec.rb 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

pedrofurtado commented 1 year ago

@odairbr Odair, fiz uma correção ha pouco no CI do projeto, poderia dar um pull na sua branch da master aqui do repositorio?

Em seguida, CI ficando verde, ja faço o merge e lanço versão. Obrigado! 🍻

odairbr commented 1 year ago

Obrigado, Pedro! :beers: