search

pedrofurtado / qrcode_pix_ruby

Ruby gem for QRCode generation of Pix (Pagamento Instantâneo Brasileiro - Banco Central do Brasil)
https://rubygems.org/gems/qrcode_pix_ruby
MIT License
43 stars 7 forks source link

Fixes and suggestions from PR #7 #8

Closed pedrofurtado closed 3 years ago

pedrofurtado commented 3 years ago

@marciojg Some fixes (in orthography) and suggestions from recently merged PR #7 🤝

PS: Can you test if you have access to approve/disapprove the PR and merge/close it? If not, please let me know that I grant access for you in repo settings.

codecov-commenter commented 3 years ago

Codecov Report

Merging #8 (c40a4da) into master (6919b9a) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          205       205           
=========================================
  Hits           205       205
Impacted Files Coverage Δ
lib/qrcode_pix_ruby/payload.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6919b9a...c40a4da. Read the comment docs.

marciojg commented 3 years ago

@pedrofurtado Good eyes. Thanks for the fixes! 👍

The merge is coming 😋