Update README - Githubissues

mcaceresb commented 1 year ago

Replaced honest_did functions in README with versions in asheshrambachan/HonestDiD
Sync README.Rmd and README.md
May or may not fix issue 1. It fixes the latest reported problem, but not sure about the original issue.

@jonathandroth Questions:

Current readme uses npre <- sum(1*(es$egt < 0)); should it be -1 like in HonestDiD README?
Current function sets grid.ub and grid.lb to -1 and 1. Should it be left to the user as in HonestDiD README?

jonathandroth commented 1 year ago

Thanks, Mauricio! I wrote the version in the honestdid readme. Pedro wrote the one here. If Pedro is okay with it, I would just copy the one from honestdid here.

On Mon, May 8, 2023, 1:23 AM pedrohcgs @.***> wrote:

Merged #4 https://github.com/pedrohcgs/CS_RR/pull/4 into main.

— Reply to this email directly, view it on GitHub https://github.com/pedrohcgs/CS_RR/pull/4#event-9185254741, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE6EXFBYVPLY4JKAD7S7Q53XFA4HZANCNFSM6AAAAAAXZGOQH4 . You are receiving this because you were mentioned.Message ID: @.***>

pedrohcgs commented 1 year ago

Totally ok with me!

On Mon, May 8, 2023 at 03:14 Jonathan Roth @.***> wrote:

Thanks, Mauricio! I wrote the version in the honestdid readme. Pedro wrote the one here. If Pedro is okay with it, I would just copy the one from honestdid here.

On Mon, May 8, 2023, 1:23 AM pedrohcgs @.***> wrote:

Merged #4 https://github.com/pedrohcgs/CS_RR/pull/4 into main.

— Reply to this email directly, view it on GitHub https://github.com/pedrohcgs/CS_RR/pull/4#event-9185254741, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AE6EXFBYVPLY4JKAD7S7Q53XFA4HZANCNFSM6AAAAAAXZGOQH4

. You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/pedrohcgs/CS_RR/pull/4#issuecomment-1537943576, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABE7344OCVLQLBE5KBDDPK3XFCTNLANCNFSM6AAAAAAXZGOQH4 . You are receiving this because you modified the open/close state.Message ID: @.***>

--

Pedro H. C. Sant'Anna https://psantanna.com https://psantanna.com

mcaceresb commented 1 year ago

@jonathandroth @pedrohcgs Thanks! I did copy the HonestDiD version, but both are subject to the notes I made in asheshrambachan/HonestDiD#27

pedrohcgs / CS_RR

Update README #4

--