search

pedrolcl / frameless-qt-poc

FramelessWindow with Qt POC
BSD 3-Clause "New" or "Revised" License
9 stars 3 forks source link

Add new function and a small improvement #1

Closed CM0use closed 1 year ago

CM0use commented 1 year ago

I was wondering if this repository is open to pull request, I am interested in making changes to the repository.

pedrolcl commented 1 year ago

I am, in general, open to contributions. But the answer to your question depends on your concrete proposal. You should explain what you are wanting to add and what improvements you are planning.

Anyway, I don't appreciate that you have already used modified versions of FramelessWindow in your own projects, removing my copyright notice and without citing/crediting the original work anywhere. The license of this class is clearly stated in both the header and the source file:

Copyright (c) 2022, Pedro López-Cabanillas <plcl@users.sf.net>. All rights reserved.

Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

  1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. ...

You have obviously not respected this license in your projects: https://github.com/CM0use/GenPassword and https://github.com/CM0use/TimeOut

You can fork the project and also re-license this class under the GPL, but you are not allowed to remove the original copyright. Instead, you may add your own copyright. You may find many explanations about this on the net. Plase read also the following article: https://www.linuxfoundation.org/blog/blog/copyright-notices-in-open-source-software-projects

CM0use commented 12 months ago

removing my copyright notice and without citing/crediting the original work anywhere.... You have obviously not respected this license in your projects: https://github.com/CM0use/GenPassword and https://github.com/CM0use/TimeOut

Sorry I am new to github, I have already updated my repository mentioned above giving credit to you. You should explain what you are wanting to add and what improvements you are planning.

I would like to make a pull request with 2 changes: Change the if/else of the FramelessWindow::updateCursor method to a switch (I've seen on the internet that it improves performance).

Add an option to disable the custom title bar(m_pseudoCaption) and show the OS title bar, disappearing certain widgets from the custom title bar. This to be more similar to the functionality that programs like Firefox or Chromium have.

I already have the changes in my fork, let me know if you want this functionality in your repository and I will make the pull request.

pedrolcl commented 12 months ago

removing my copyright notice and without citing/crediting the original work anywhere.... You have obviously not respected this license in your projects: https://github.com/CM0use/GenPassword and https://github.com/CM0use/TimeOut

Sorry I am new to github, I have already updated my repository mentioned above giving credit to you.

Don't worry. Nobody knows everything all the time. I can see that you have also fixed the attribution of the SwitchButton. Nice! In the future you may like to explore the new SPDX format to mark the source files with formal license references.

You should explain what you are wanting to add and what improvements you are planning.

I would like to make a pull request with 2 changes: Change the if/else of the FramelessWindow::updateCursor method to a switch (I've seen on the internet that it improves performance).

Add an option to disable the custom title bar(m_pseudoCaption) and show the OS title bar, disappearing certain widgets from the custom title bar. This to be more similar to the functionality that programs like Firefox or Chromium have.

I already have the changes in my fork, let me know if you want this functionality in your repository and I will make the pull request.

I like all your proposals. Go ahead with the PR. Tell me if you need any help. Yo también hablo español, si te resulta mas cómodo.

CM0use commented 12 months ago

Don't worry. Nobody knows everything all the time... In the future you may like to explore the new SPDX format to mark the source files with formal license references.

Thanks for the advice, I'll take a look at the link.

I like all your proposals. Go ahead with the PR. Tell me if you need any help. Yo también hablo español, si te resulta mas cómodo.

I would like to speak in Spanish but this way I practice English and anyone can understand me more easily.