search

pedromassango / bottom_navy_bar

A beautiful and animated bottom navigation
https://youtu.be/jJPSKEEiN-E
Apache License 2.0
1.02k stars 216 forks source link

Bar is to low at iPhone X(s/R) #13

Closed kay4ik closed 5 years ago

kay4ik commented 5 years ago

At the Bottom of the iPhone X... is the Navigation "Line". At this point there should be white space. The Navy Bar is behind this Line.

image

How it should look:

image

pedromassango commented 5 years ago

Hi Kay4ik, can you try please too wrap the BottomNavyBar with a SafeArea widget? I don't have a Mac to try it. Thank you

kay4ik commented 5 years ago

Hey @pedromassango, I tried and it works 👍

image

Here is my Code:

Container(
      decoration: BoxDecoration(
        color: Colors.white,
        boxShadow: [
          BoxShadow(
            offset: Offset(0,6),
            blurRadius: 6,
            spreadRadius: 8,
            color: Colors.grey,
          )
        ]
      ),
      child: SafeArea(
        child: BottomNavyBar(
          showElevation: false,
          ...

I wrapped the SafeAre in a Container to color the Area below the Navybar white. When showElevation: true then the Bar shows the Elevation on top AND on bottom. This is how it looks without Container and with ELevation:

image

pedromassango commented 5 years ago

Great. Thank you for this @kay4ik. Maybe you want to make a pull request with this contribuition?!

Or I can just do it by my self. Thanks

pedromassango commented 5 years ago

Fixed since this version: 5.0.0