search

pedromassango / bottom_navy_bar

A beautiful and animated bottom navigation
https://youtu.be/jJPSKEEiN-E
Apache License 2.0
1.02k stars 215 forks source link

Added containerHeight property #41

Closed lukevenediger closed 4 years ago

lukevenediger commented 4 years ago

Added a property to allow customising the container height for the bottom bar.

pedromassango commented 4 years ago

Hi, thanks for this PR. I'm wondering if we must hallow a custom navigation bar height as our goal is to follow the Material Design guidelines (that use 56 as the fixed navigation bar's height)

lukevenediger commented 4 years ago

Hi, I suggest making it an optional setting that defaults to the Material Design guidelines. I would like to adjust it to suit my needs and don't mind deviating from the guidelines. If a user ignores it, it will confirm to the standard.

pedromassango commented 4 years ago

Right. This will be merged soon!