pedromassango / bottom_navy_bar

A beautiful and animated bottom navigation
https://youtu.be/jJPSKEEiN-E
Apache License 2.0
1.03k stars 217 forks source link

add key param to GestureDetector #44

Closed HiroyukiTamura closed 4 years ago

HiroyukiTamura commented 4 years ago

I think GestureDetector of ItemWidget having Key is useful for integration testing.

VictorUvarov commented 4 years ago

The key should not be associated on the class itself since all descendants of widget already has a key member.

BottomNavyBarItem({
    Key key,
    @required this.icon,
    @required this.title,
    this.activeColor = Colors.blue,
    this.textAlign,
    this.inactiveColor,
  }) {
  super(key:key);
  ...