pedronauck / micro-router

:station: A tiny and functional router for Zeit's Micro
https://www.npmjs.com/microrouter
MIT License
623 stars 34 forks source link

Move `micro` to the `dependencies` #36

Closed mikenikles closed 6 years ago

mikenikles commented 6 years ago

Since micro is used at https://github.com/pedronauck/micro-router/blob/7779f333ad2034243711ba22d70966dad1f6a1f3/lib/index.js#L2, it should be listed in dependencies instead of devDependencies to avoid errors when installing packages.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 1345c7a9ad6417801d6ac06b826460eb29fcd568 on mikenikles:patch-1 into 04bdeaf28ec48803ceab13fabfc74fbd6f6958e9 on pedronauck:master.

MiniGod commented 6 years ago

Relates to #25 and #26.

Maybe it should be both a peerDependency and a devDependency?