search

pedropombeiro / gitextensions

Fork on GitExtensions to provide integration with CI build servers. At an initial stage, TeamCity support, and in the future, Team Foundation Server support (with room for others). GitExtensions is a shell extension, a Visual Studio 2008 plugin and a standalone Git repository tool.
http://code.google.com/p/gitextensions
GNU General Public License v3.0
4 stars 1 forks source link

Move build server settings to Settings dialog. #2

Closed jbialobr closed 11 years ago

jbialobr commented 11 years ago

Also add setting to disable showing build report inspite of existing properly configured .buildsever file.

pedropombeiro commented 11 years ago

Is it OK to place this page outside the Plugins node? From what I see, the plugin pages are autogenerated, and only contain text boxes.

jbialobr commented 11 years ago

We are about to reorganize settings pages tree, so yes (maybe it will be moved in the future).

pedropombeiro commented 11 years ago

Do you know how do I get the Module.GitWorkingDir from inside a SettingsPageBase?

jbialobr commented 11 years ago

You cann't. You can change it's base to GitModuleControl or pass GitModule instance to your page directly as in LocalSettingsSettingsPage.

pedropombeiro commented 11 years ago

OK. The settings page is there now. Just miss the checkbox to disable integration.

jbialobr commented 11 years ago

There should be some validations performed before trying to save config.

System.ArgumentNullException was caught Message=Wartość nie może być zerowa. Nazwa parametru: Value cannot be null Source=Nini ParamName=Value cannot be null StackTrace: w Nini.Config.ConfigBase.Set(String key, Object value) w GitUI.CommandsDialogs.SettingsDialog.Pages.BuildServerIntegrationSettingsPage.<>cDisplayClass3.b2(String x) w D:\projekty\gitextensions\GitUI\CommandsDialogs\SettingsDialog\Pages\BuildServerIntegrationSettingsPage.cs:wiersz 70 w GitCommands.FileInfoExtensions.MakeFileTemporaryWritable(String fileName, Action`1 writableAction) w D:\projekty\gitextensions\GitCommands\FileInfoExtensions.cs:wiersz 18 w GitUI.CommandsDialogs.SettingsDialog.Pages.BuildServerIntegrationSettingsPage.SaveSettings() w D:\projekty\gitextensions\GitUI\CommandsDialogs\SettingsDialog\Pages\BuildServerIntegrationSettingsPage.cs:wiersz 58 InnerException:

pedropombeiro commented 11 years ago

Added checkbox to enable integration and fix exception with latest commit.