Fixed comparing int to float bug

pedrovgs / DraggablePanel

Android library used to create an awesome Android UI based on a draggable element similar to the last YouTube graphic component.

Apache License 2.0

2.99k stars 605 forks source link

Fixed comparing int to float bug #25

Closed IlyaGazman closed 9 years ago

IlyaGazman commented 9 years ago

After video been minimized I wasn't been able to dismiss it, because it compared int to float

This fix solves it.

pedrovgs commented 9 years ago

Hi @IlyaGazman! Thanks for your pull request :)

Review your branch, your PR is breaking the build.

Related to the code, I'm going to fix this issue changing some variables using float to use int, because it should be declared as int xD. Your PR doesn't fix the bug I have with VideoView sample and compare floats using a delta is not the best approach.

pedrovgs commented 9 years ago

I've merged other pull request from @Fiddl3 that fixes one problem with ResizeTransformer and apply some changes that are not compatible with this PR. I'm going to close this PR.