search

pedrovgs / DraggablePanel

Android library used to create an awesome Android UI based on a draggable element similar to the last YouTube graphic component.
Apache License 2.0
2.99k stars 606 forks source link

Resize transformer fix #27

Closed Fiddl3 closed 9 years ago

Fiddl3 commented 9 years ago

Many changes, please look at commit comments. I tried to commit small code changes related to one issue at time.

ResizeTransformer should now work more smoothly, because layout is redrawn only once in one pass of Drag Listener.

I removed some unnecessary methods an simplified Transformers code...

pedrovgs commented 9 years ago

Nice PR, can you update this branch with pedrovgs:develop?

Fiddl3 commented 9 years ago

Travis say Could not find com.android.support:support-v4:21.0.2. xD There is no support library on maven central (I think is in local repo, when you install android google support libs via SDK Manager)

pedrovgs commented 9 years ago

xD Revert your build.gradle changes to use an older version. I'll update that dependencies later.

Fiddl3 commented 9 years ago

MINIMUN_DX_FOR_HORIZONTAL_DRAG typo in MINIMU``N word

...MIN_VELOCITY - I've tested various values and this to works ok for me, Y_MIN_VELOCITY was too high for landscape mode.

pedrovgs commented 9 years ago

Can you restore the value of MINIMUN_DX_FOR_HORIZONTAL_DRAG to 5?

Fiddl3 commented 9 years ago

hmmmm.... I'm thinking MINIMUM_DX & MINIMUM_DY should be density dependent...

pedrovgs commented 9 years ago

Yes, should be density dependent. We can do that in other PR.

pedrovgs commented 9 years ago

There is something wrong with tv shows sample, ScaleTransformer and this branch :S. Here you have a video https://drive.google.com/file/d/0B9xkpTnF9BXjbDZQcU4tR1ZfblE/view?usp=sharing Can you take a look. This is the last fix needed to merge this PR :)

Fiddl3 commented 9 years ago

Whats wrong there? I don't know where I should look

Fiddl3 commented 9 years ago

aaa I see, second view content is missing, I'll take look at this

pedrovgs commented 9 years ago

Review also how you measure your max bottom position. I've changed your <item name="y_scale_factor" format="float" type="dimen">2</item> to <item name="y_scale_factor" format="float" type="dimen">2.3</item> and is working as you can see in this video: https://drive.google.com/file/d/0B9xkpTnF9BXjZndQOE9vSDNCa0E/view?usp=sharing

Fiddl3 commented 9 years ago

travis doesn't like me & lastest google support library.... Travis downloads and installs support library, but then it doesn't see it... https://travis-ci.org/pedrovgs/DraggablePanel/builds/43138658#L935

pedrovgs commented 9 years ago

Thanks @Fiddl3 for this pull request!!!! I'm going to update project readme with a contributors section and you will be there :) What's your name and last name?

Fiddl3 commented 9 years ago

No problem :) I'll continue working on lanscape support when I'll have time I'm Rafał Pluta

pedrovgs commented 9 years ago

If you are using this library in any project, please send me an email with the project name and link to update README.md file with that information.

2014-12-06 14:20 GMT+01:00 Fiddl3 notifications@github.com:

No problem :) I'll continue working on lanscape support when I'll have time I'm Rafał Pluta

— Reply to this email directly or view it on GitHub https://github.com/pedrovgs/DraggablePanel/pull/27#issuecomment-65896706 .

Fiddl3 commented 9 years ago

This project is still in dev stage, I still have problems with rtmp stream playback...

pedrovgs commented 9 years ago

Ok, let me know once be published! Good luck ;) On Dec 6, 2014 3:39 PM, "Fiddl3" notifications@github.com wrote:

This project is still in dev stage, I still have problems with rtmp stream playback...

— Reply to this email directly or view it on GitHub https://github.com/pedrovgs/DraggablePanel/pull/27#issuecomment-65898965 .

Fiddl3 commented 9 years ago

I will, thanks.