pedrovgs / Shot

Screenshot testing library for Android
Apache License 2.0
1.18k stars 115 forks source link

Support dynamic-feature Modules #256

Open RainNapper opened 3 years ago

RainNapper commented 3 years ago

Expected behaviour

Can test individual views within dynamic feature modules without testing the entire app.

Actual behaviour

Looks like the tests fail to run:

java.util.concurrent.ExecutionException: com.android.tools.build.bundletool.model.exceptions.InvalidCommandException: The APK Set archive does not contain the following modules: [name-of-dynamic-feature-module]

Steps to reproduce

Follow setup steps for Shot on a dynamic feature module, and run tests.

Version of the library

5.11.2

It could be that there's something wrong locally, but before closing, could y'all confirm that this is supposed to work on DFMs?

pedrovgs commented 2 years ago

@RainNapper thanks for reporting. I'm afraid I've never tested shot for dynamic modules. If you create a sample project I can check if the configuration is correct.