Directory suffix - Githubissues

pedrovgs / Shot

Screenshot testing library for Android

Apache License 2.0

1.19k stars 116 forks source link

Directory suffix #259

Closed CedrickFlocon closed 2 years ago

CedrickFlocon commented 3 years ago

:pushpin: References

Issue: https://github.com/pedrovgs/Shot/issues/86, https://github.com/pedrovgs/Shot/issues/258

:tophat: What is the goal?

This pull request aims to improve the directory management

How is it being implemented?

ShotFolder class will be responsible of all directory structure.

What's Next

Update ShotExtension to add directoryPrefix as an Option.
And construct ShotFolder with this field when it's defined.
Move hard coded file name & path from Shot.scala to ShotFolder.scala

How can it be tested?

[x] Use case 1: Product Flavor & Directory suffix
- [x] run ./gradlew :shot-consumer-flavors:greenExecuteScreenshotTests -PdirectorySuffix=Api26
[x] Use case 2: Directory suffix
- [x] run ./gradlew :shot-consumer:executeScreenshotTests -PdirectorySuffix=Api26

CedrickFlocon commented 3 years ago

It's ready for review @pedrovgs.