Closed badoualy closed 2 years ago
@pedrovgs It should be fine now.
When I run the command locally, every scala file is reported as Files incorrectly formatted 🤔 (even the ones I didn't edit) So if it's still not OK, not sure what's wrong.
We should add specific coverage yeap.
I'll see what I can do
Why don't we replace this with a UUID? I think the timestamp is going to be generated for each run btw.
We can
Edit: I tested, the try/catch part is ok, the directory suffix is NOK, looks like files are not renamed when copied from device, I'll attempt to fix when I have more time
Edit2: pullScreenshots
is not taking in account shotFolder.pulledScreenshotsFolder()
😄
@pedrovgs The UUID solution won't work, because the UUID will be different between the downloadScreenshots
task and the ExecuteScreenshotTests
task as they are run separately.
So we can keep the try/catch to avoid having the task fail and still generate the report. But the next run will still fail unless the file is deleted manually 🤷
@pedrovgs what about GithubActions? Have no experience with it, but I see in this blog post that one could run tests on specific machines?
:pushpin: References
:tophat: What is the goal?
Attempt to fix issues with gradle process locking files on windows.
How is it being implemented?
removeProjectTemporalScreenshotsFolder
call belowgenerateVerificationReport
to avoid crashing before the report is generateduid
suffix for the pulled screenshot foldersdelete
call in a try/catch to not crashHow can it be tested?
No particular step. But I didn't test yet, I need to try publishing it on my local maven repo or use jitpack.
Note
System.currentTimeMillis().toString
part, first time writing scala, not sure if the timestamp will be generated at each run, or once when the plugin is configured.The PR is more of a draft/suggestion to help the author rather than a ready-to-merge PR. If you have feedbacks I can try improving it.