Support configuration cache (second attempt) - Githubissues

pedrovgs / Shot

Screenshot testing library for Android

Apache License 2.0

1.18k stars 116 forks source link

Support configuration cache (second attempt) #307

Closed MyDogTom closed 2 years ago

MyDogTom commented 2 years ago

:pushpin: References

Issue: https://github.com/pedrovgs/Shot/issues/263
Related pull-requests:https://github.com/pedrovgs/Shot/pull/291

:tophat: What is the goal?

Ensure that configuration cache works after Gradle daemon is recreated.

How is it being implemented?

Avoid using global variable because Gradle has no idea about it and cannot recreate when configuration cache is reused. Use explicit task input instead.
Annotate other task inputs.
Convert internal "shot" property to function. It's used only once by each task anyway.

How can it be tested?

./gradlew debugExecuteScreenshotTests --configuration-cache
./gradlew --stop
./gradlew debugExecuteScreenshotTests --configuration-cache - should display "Reusing configuration cache."

MyDogTom commented 2 years ago

@pedrovgs I was thinking about enabling configuration cache in the sample project, but this depends on AGP update and can be done only after https://github.com/pedrovgs/Shot/pull/292 is merged. Once sample app has configuration cache enabled, it should be possible to automate the same scenario.