Some code styling improvements

peduarte / wallop

:no_entry: currently unmaintained :no_entry: A minimal JS library for showing & hiding things

1.1k stars 79 forks source link

Some code styling improvements #53

Closed jacobmllr95 closed 9 years ago

jacobmllr95 commented 9 years ago

Remove spaces between function and braces
Make sure every comment starts with a space and a capital letter
_this => self
Some other small tweaks

peduarte commented 9 years ago

Hey @jackmu95

I might be missing something, but I am not sure this is an improvement, just personal coding styles.

Thanks anyway 👊

jacobmllr95 commented 9 years ago

Hey @peduarte

I'am a big fan of strict code styling guidelines and hate inconsistencies. I saw that function was sometimes written like function() { ... } and sometime like function () { ... } (see the space between the function and the braces), so I thought I submit a PR to fix this.

If my PR was an improvement or not was your decision, but I have no problem to see it closed :)

peduarte commented 9 years ago

No worries, appreciate it anyway! :)