peduarte / wallop

:no_entry: currently unmaintained :no_entry: A minimal JS library for showing & hiding things
1.1k stars 79 forks source link

Add bower.json #78

Closed norbert-codes closed 7 years ago

norbert-codes commented 7 years ago

Created initial version of bower.json, as mentioned in issue #77. Bower.json is based on the projects package.json and the official spec. Both .js (unminified) and .css are included in main, so a fully working copy of Wallop will be available if these files are picked.

peduarte commented 7 years ago

Is this enough to solve your problem?

I swear I had a bower.json spec. Because you can install it from bower already. I just took a look at their docs and it says that in order to create a package there must be a bower.json spec so I'm wondering how it's currently working? haha You can see its currently available here Probably because I registered with bower and bower basically just downloads the latest release.

Anyway, if you are 100% this file is correct I'll merge and release. Let me know, cheers

norbert-codes commented 7 years ago

Honestly Im not entirely sure :), I got a bit confused, when realised that the project didn't have a bower.json, but still was available via bower. Will check how it was possible and see if its enough or not. Sorry for the late reply, I dont have that much time these days, but will look into it further this week and let you know.

peduarte commented 7 years ago

No worries. I agree it's worth double checking to ensure we don't release a broken build.

👌

norbert-codes commented 7 years ago

Sorry for the delay... I looked into it, and still don't really know how it was possible, that the project doesn't have a bower.json, and still was available. :) I think somehow it was just auto-generated, with the bare minimum only. I think (but not sure) we can just add bower.json, so it will be used after, instead of the "generated one".

But there is another thing... We and I suppose many others actively moving away from Bower in favor of yarn and Webpack. So Im not sure if it is that relevant any more. Whats your opinion?

peduarte commented 7 years ago

@nygdjs I don't think it's necessary either. I'd be happier to leave it as it is, but I'd be willing to add if it will help you and if you're sure of how to add it.

norbert-codes commented 7 years ago

Sorry for the delay... So... I think it's not necessary at this point either. And sorry for the fuss with it. Seemed more important a few weeks ago.

peduarte commented 7 years ago

No worries :)