search

peej / lumberjack-keyboard

5x12 ortholinear through-hole component keyboard PCB for standard 60% cases
MIT License
368 stars 61 forks source link

Current gerbers don't have default dimensions #7

Closed Wanja-L closed 2 years ago

Wanja-L commented 2 years ago

When uploading the zipped PCB gerbers from latest master to JLCPCB the dimensions aren't automatically filled in:

image

If I switch to tag 1.6 and upload those gerbers it fills them in:

Screen Shot 2022-05-19 at 7 42 16 PM

Not sure if the dimensions stayed the same between the versions so I figured I'd raise it here.

I'd open a PR but I have no idea how to use KiCad. I'll download it and see if I can figure it out but if you beat me to it I wouldn't be mad either :)

peej commented 2 years ago

This appears to be an issue with the JLCPCB gerber loader, if the gerbers take too long to process for whatever reason then it cannot determine the size of the PCB.

I've tried exporting the gerbers with different settings but nothing I've tried appears to "fix" the issue.

Gerbers themselves only contain the shapes, JLCPCB determines the PCB size from the shapes in the outline layer within the gerber.

Perhaps an update to the documentation specifying this and the PCB dimensions to use would be the best solution until JLCPCB fix their form.

Wanja-L commented 2 years ago

Thanks for the quick response and explanation. I was about to start a PR and saw that you beat me to it, much appreciated.