peek-travel / cocktail

Elixir date recurrence library based on iCalendar events
https://hexdocs.pm/cocktail
MIT License
218 stars 30 forks source link

Remove dependency on Timex #296

Closed davydog187 closed 1 year ago

davydog187 commented 1 year ago

Hello 👋🏼 Very cool library, thanks for sharing this great work!

I am evaluating Cocktail and noticed the dependency on Timex with a transitive dependency on combine. As far as I can tell, most of the use of Timex is now supported by the Elixir standard library, with a few notable exceptions:

Github Search for Timex usage in Cocktail

Assuming we can find suitable solutions to the above functions, would you be interested in a PR that removes the dependency on Timex?

Thanks!

davydog187 commented 1 year ago

On further investigation, this library makes use of Timex types to express durations that do not exist in the standard library. I don't think it would be worth trying to cut this over.