Closed tekkies closed 8 years ago
Having just restarted Atom again, I get "Verify 'PlantUML Jar Location' in settings."
I set the path to the jar (without double quotes!) and it seems to be working now.
Initial issue: Sounds like something might not be correct in the 'Use Temp Directory' setting or handling. I'll look into it.
Comment: I can update the setting description for paths to include a note about the quotes or strip the characters off. Not sure what approach other packages take with file paths.
Seems the error is caused by the PlantUML jar location being incorrect, but the message just says that there was no resultant svg. Maybe if there's no svg for the preview, check the JAR location is valid report a JAR missing error instead of report-not-generated. Just a thought.
I see the issue. I attempt to detect if the JAR path is incorrect but it doesn't work if it is incorrect on the first attempt:
What I was expecting to see:
But that only works if the file is present. I'll rework that logic.
Sounds good.
Think commit 437b32d63f95f9666e793a8505e8452e3060e84b handles the issue.
[Enter steps to reproduce below:]
Note: a components.svg file already exists in the same folder as components.plantuml.
Atom Version: 1.3.2 System: Microsoft Windows 8.1 Enterprise Thrown From: plantuml-preview package, v0.11.0
Stack Trace
Uncaught Error: ENOENT: no such file or directory, open 'C:\Users\ajoiner\AppData\Local\Temp\plantuml-preview\components.svg'
Commands
Config
Installed Packages