Deserialize values when deserializing ORMap

peer-base / js-delta-crdts

Delta State-based CRDTs in Javascript

192 stars 16 forks source link

Deserialize values when deserializing ORMap #22

Closed jimpick closed 5 years ago

jimpick commented 5 years ago

In peer-star-app, our MVReg values weren't getting stored as DotSet objects in the state.

pgte commented 5 years ago

@jimpick Thank you for this! I'm curious, what was the symptom that lead you to this fix?

jimpick commented 5 years ago

I was trying to understand some strange behaviour with connection management, and I started to dump some of the CRDT state with .state() and I didn't understand what I was seeing. Also, I think this may have been the source of some exceptions I was seeing on the pinners that I hadn't investigated yet.

The strange connection behaviour seems to be a different problem though...

pgte commented 5 years ago

Landed on v0.5.2