search

peer-base / js-delta-crdts

Delta State-based CRDTs in Javascript
192 stars 16 forks source link

embedded ormap failing test #24

Closed salzhrani closed 5 years ago

salzhrani commented 5 years ago

I used all causal CRDTs this time the last expect is failing

pgte commented 5 years ago

Hi @salzhrani, thanks for this PR!

I think this is another version of this PR: https://github.com/ipfs-shipyard/js-delta-crdts/pull/19#issuecomment-431565493, where I commented something that I believe also applies here:

I've been discussing this issue, and it looks like it's a consequence of how the ORMap works.

Because the absence of a key is defined by the value of the CRDT it points to being at the "bottom", which is the case.

Looks like this is a "feature" (that should be explained in the README).

@salzhrani does this explain the failure of your test?

salzhrani commented 5 years ago

I guess it does. This is very unaccessible... the paper and algorithms not your code, it's very straightforward.

Thank you.