search

peer-base / js-delta-crdts

Delta State-based CRDTs in Javascript
194 stars 16 forks source link

Encode ids in mvreg #41

Closed jimpick closed 5 years ago

jimpick commented 5 years ago

Peer-base uses Buffers for ids, which were getting serialized in strange ways so the mvreg CRDT wasn't converging when syncing.

See: https://github.com/peer-base/peer-base/issues/287

This fix encodes the ids to strings, using a similar method as what is used in the rga type.

pgte commented 5 years ago

@jimpick could you get the CI green?

jimpick commented 5 years ago

Seems like it was an old failure due to npm dependencies ... I re-ran the tests and it passed.

pgte commented 5 years ago

BTW, I don't have merge rights, but this LGTM

jimpick commented 5 years ago

Okay, I merged it. I think the permissions are definitely screwy now.

Do you plan to keep maintaining this one?

I'll request collaborator access on this repo from IT, and then I can add you back.

pgte commented 5 years ago

@jimpick yes, no worries, I can keep maintaining this.

jimpick commented 5 years ago

Excellent! I'm trying to get added as a collaborator, then theoretically I can add you back on as well.

jimpick commented 5 years ago

I tracked down admin rights, and added @pgte back in as an admin collaborator.