search

peer-base / peer-pad

📝 Online editor providing collaborative editing in really real-time using CRDTs and IPFS.
https://peerpad.net
MIT License
678 stars 57 forks source link

Tc/mobile nav #160

Closed designsaves closed 6 years ago

olizilla commented 6 years ago

@designsaves hi 👋, this PR isn't failing CI because of anything you did, it's just that CI is using the old version of enzyme-to-json. If you want to fix this PR today then you'll need to manually add the missing line to the snapshot shown here: https://travis-ci.org/ipfs-shipyard/peer-pad/builds/376539290#L5081

It might be easier to wait for #164 to be merged and then update your PR from master.

designsaves commented 6 years ago

Thanks @olizilla I'll wait for #164 to be merged. Oh and hi! 👋

one000mph commented 6 years ago

@olizilla can this be merged now?

jacobheun commented 6 years ago

@designsaves #164 has been merged, you should be able to rebase from master and push now. The conflicts will need to get resolved, but that should fix the build failure.

designsaves commented 6 years ago

@olizilla @jacobheun Thanks! I'm working on this today.

jacobheun commented 6 years ago

@designsaves this looks good, but it looks like there is an issue with style changes in the internal mobile nav once you hit "start" and get into the application.

image

designsaves commented 6 years ago

Ok, great! Looks like this is ready to merge pending your review @jacobheun. Thanks!