search

peer-base / peer-pad

📝 Online editor providing collaborative editing in really real-time using CRDTs and IPFS.
https://peerpad.net
MIT License
678 stars 56 forks source link

WIP: Chore/upgrade deps #223

Closed pgte closed 5 years ago

pgte commented 5 years ago

Currently failing with:

this.htmlWebpackPlugin.getHooks is not a function
pgte commented 5 years ago

@satazor do you think you can help with your webpack chops here? :)

satazor commented 5 years ago

It seems that the build script needs to be updated, because this seems like an ejected CRA correct?

Because you upgrade the CRA related dependencies to the latest version,I suggest to create a new CRA app, eject it and update the scripts/ with the new ones but also keeping what changed.

satazor commented 5 years ago

Moreover, there's stuff that should be copied as well, such as jest config: https://github.com/ipfs-shipyard/peer-pad/blob/4ba773f65c43de46989fb99fee5bde3bed53fd92/package.json#L105

@pgte want to me take a stab on this or my suggestions are sufficient?

pgte commented 5 years ago

@satazor could you please lend a hand here?

satazor commented 5 years ago

Will do.

satazor commented 5 years ago

@pgte Here it is: https://github.com/ipfs-shipyard/peer-pad/pull/239

Please read the PR description as it contains valuable info.

jimpick commented 5 years ago

I'm going to try to freshen this up and get the deps upgraded...

jimpick commented 5 years ago

I'm going to merge these ... there's a few more to upgrade - I'll do those in a separate PR.