peer-base / peer-pad

📝 Online editor providing collaborative editing in really real-time using CRDTs and IPFS.
https://peerpad.net
MIT License
678 stars 56 forks source link

Clean frontend #238

Closed victorb closed 5 years ago

victorb commented 5 years ago

From https://github.com/ipfs-shipyard/pm-peer-pad/issues/35

Beginning with making sure linting + tests passes.

victorb commented 5 years ago

This PR is now ready for review, cc @pgte and @jimpick

Easiest to review by going by commit:

jimpick commented 5 years ago

Excellent! I will review in a few hours and try deploying to my staging environment.

victorb commented 5 years ago

Having some issues in CI with PeerPad currently. This is the error which happens when running npm ci, but I cannot reproduce locally.

npm ERR! code E404
npm ERR! 404 Not Found: flatmap-stream@0.1.1

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2018-11-29T02_46_31_747Z-debug.log
victorb commented 5 years ago

Needs an update as package.json and package-lock.json are no longer in sync. I'm on it.

victorb commented 5 years ago

Ready for review again

victorb commented 5 years ago

Version can be tried out here: https://ipfs.io/ipfs/QmWMDrh8yHuyqhFYUvH4BJ27pKBbCUuKYzpP3KgRAH1QQV/ (cc @parkan might want to try out the new UI)

parkan commented 5 years ago

looks good with the exception of the promise changes

victorb commented 5 years ago

Sweet! We're just missing a review by @jimpick then AFAIK

jimpick commented 5 years ago

I deployed it here: https://peer-pad-staging.jimpick.com/

It seems to work, and the pinner works too.

It's extremely slow to make connections though. We'll have to work on that.

Also, we need the UI to show the sync status to the pinner - it's too easy to close the browser tab early before the data is synced.

LGTM!

jimpick commented 5 years ago

Not sure about the Jenkins failure ... I don't know anything about that setup.

parkan commented 5 years ago

nice work!