search

peer-base / peer-pad

📝 Online editor providing collaborative editing in really real-time using CRDTs and IPFS.
https://peerpad.net
MIT License
678 stars 56 forks source link

Add greenkeeper? #242

Closed jimpick closed 5 years ago

jimpick commented 5 years ago

Should we add greenkeeper to this project?

pgte commented 5 years ago

I think we should, after #223 is merged.

mikeal commented 5 years ago

I'm a big greenkeeper fan, but I will warn that it can be quiet noisy. I'm used to dealing with a lot of email but if ya'll are used to a fairly clean inbox you might be in for a surprise :)

daviddias commented 5 years ago

Good reads on how the IPFS Community thinks about Greenkeeper:

(Not blocking, just for context, also today we have a different CI)

jimpick commented 5 years ago

It looks like it might be useful if the project has a simple set of dependencies, but is a hindrance if a project is quite complicated...

Right now, I think peer-pad has a complicated dependency set (create-react-app was ejected?) ... it would be nice to move it to something simpler over time.

Looking at the number of dependencies, it's probably best if we don't use greenkeeper for the time being and just upgrade manually on a regular basis.

parkan commented 5 years ago

the eject happened here: https://github.com/ipfs-shipyard/peer-pad/commit/829aa7163bab5a286fe05e44db796ae26888ba66#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

agreed on keeping greenkeeper quiet for now, especially with github's new vulnerability warnings