search

peer-base / peer-pad

📝 Online editor providing collaborative editing in really real-time using CRDTs and IPFS.
https://peerpad.net
MIT License
678 stars 56 forks source link

When using 'npm start' for dev, indicate to developer that they also need to run rendezvous server #258

Open jimpick opened 5 years ago

jimpick commented 5 years ago

With PR #253, we now configure peer-pad to use a rendezvous server running on localhost when the developer runs npm start. If the developer doesn't read the documentation, they might not know that they need to also run npm run start:rendezvous ... if they don't the application prevents editing, and it's not really obvious what is happening.

In #253, we discussed either running the rendezvous server automatically, or indicating to the user that they need to run it themselves.

parkan commented 5 years ago

what happens is that the binding fails and the node silently fails to start, right?

this in itself is kind of broken (https://github.com/libp2p/js-libp2p-websocket-star/issues/61), you should generally be able to use the app in single-player mode, especially for development, though right now making that happen unfortunately requires fixing js-libp2p

pgte commented 5 years ago

Running peer-pad from local rendezvous-vous would require injecting some alternative configuration into peer-pad in compile or pre-boot-run-time.

parkan commented 5 years ago

@pgte does this not accomplish that? https://github.com/ipfs-shipyard/peer-pad/pull/253

pgte commented 5 years ago

@parkan it does, nice!