search

peer-base / peer-pad

📝 Online editor providing collaborative editing in really real-time using CRDTs and IPFS.
https://peerpad.net
MIT License
678 stars 56 forks source link

Change delimiter in links so Zoom displays clickable URLs correctly #260

Closed jimpick closed 5 years ago

jimpick commented 5 years ago

Zoom chat really doesn't like the '-' character in PeerPad URLs... when they are posted to Zoom chat, it doesn't highlight the last part of the URL, which has the write key, which results in a read-only link, which is super confusing.

It's really a bug in Zoom, but I think maybe if we switch the delimiter to an underscore or similar, we can avoid that bug.

pgte commented 5 years ago

As long as we're able to also parse the current format, I'm not opposed to generating a compatible URL. @jimpick do you mind taking a stab at it? https://github.com/ipfs-shipyard/peer-star-app/tree/master/src/keys

jimpick commented 5 years ago

It should be easy to do with a regex... I'll try to do it now.

jimpick commented 5 years ago

I coded up a complete fix... but then I discovered Zoom doesn't like the underscore either.

I experimented with the URLs a bit in a Zoom chat session, and it's actually breaking because the URLs are too long. Any portion of a URL past a certain length limit ... Zoom will chop the clickable part of the URL. :-(

I can't think of a good simple fix that doesn't involve using a URL shortener.

For now, we can just educate testers on our team to select the entire URL with their mouse and copy-and-paste it. For wider testing with Zoom users, we'll need a different solution.

jimpick commented 5 years ago

With '_' delimiter:

screenshot 2018-12-07 22 54 53

No delimiters at all, remove slash:

screenshot 2018-12-07 22 54 27
victorb commented 5 years ago

@jimpick are you using the macOS client of Zoom? Seems to be a platform dependent bug in Zooms client, as the links work properly for me on Ubuntu 18.04.

image

Have we reported this to Zoom? It's clearly not a good behaviour in the client, maybe they'll be able to solve it quickly.

jimpick commented 5 years ago

It's interesting that it works on Ubuntu - so it might be a bug they'd fix. I'll research how to report a bug to Zoom.

jimpick commented 5 years ago

I couldn't find a good bug reporting form, so I sent an email to info@zoom.us.

jimpick commented 5 years ago

I received a response from Zoom: "Our engineers have told me that this is a known issue and that it will be fixed in an update before too long."

jimpick commented 5 years ago

I tested with the current version of Zoom, and it's fixed, so I'm closing this.