peeramid-labs / contracts

Rankify smart contracts
https://rankify.it
5 stars 2 forks source link

do not create new token if it already exists (deterministic) #78

Open peersky opened 1 week ago

peersky commented 1 week ago

this is reopened #56

WIth completion of #62 it is now possible to create multiple subjects that correspond to different Rank NFT asset minting privilege.

As we go forward, this brings a ux question of supplorting multiple subjects with absolutely identical subject. Technically right now it is possible, to create two Rank Token NFTs, with identical subject.

With this ticket, we want to create token such that it can work for every subject, but will avoid duplication of Rank NFTs.

This means that there will be one Rank NFT endpoint that can mint tokens for unlimited number of instances. Following is needed:

changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: acd99ae3d2d5d77cd39dae24b66562cb01d433c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR