peercoin / coinlib

The most feature-complete *coin library in the entire Dart/Flutter ecosystem.
BSD 3-Clause "New" or "Revised" License
5 stars 8 forks source link

Script and document Windows support #23

Closed sneurlax closed 7 months ago

sneurlax commented 7 months ago

See the README.md changes and the commit history for a summary. Basically, I used flutter create --platforms=windows ., added a build_windows.dart script to be ran on Ubuntu 20.04 and capable of being ran on a Windows host in a WSL2 instance, and documented its use.

One area I see for improvement upon this PR would be to copy build_windows.dart to build_wsl.dart to be ran on WSL/WSL2 and adapt a new build_windows.dart based on build_linux.dart using a Dockerfile to implement bitcoin-core/secp256k1's cross-compilation guide.

I can also see that this might be more helpful if it were based upon or otherwise compatible with the new 2.0 work. Please let me know if work's needed in that direction.

sneurlax commented 7 months ago

force-pushed to keep state a little cleaner and remove the

No script is included for building on Windows at the present time, however a
`secp256k1.dll` may be built into your `build/` directory separately.

I left in the README.md originally.

sneurlax commented 7 months ago

OK I see your requested changes! I implemented the changes discussed in telegram first and now need to make these changes requested here. I made a windows-2.0 branch based on the v2.0 branch as a starters, from which I'll now open a draft PR. I'll mark it ready for review once the changes here have been implemented, thanks for the review and sorry for the extraneous autogenerated files!