search

peerdavid / remapy

An open source explorer for your remarkable tablet to show, upload or delete files via the remarkable cloud.
Apache License 2.0
174 stars 19 forks source link

open files on different platforms #10

Closed bzz closed 4 years ago

bzz commented 4 years ago

Thank you for sharing the code for this tool!

Right now, it includes a hard-coded calls to linux-specific tool subprocess.call(('xdg-open', XXX)).

It would be nice to have other platforms supposted (e.g. mac OS) by refactoring that to the logic similar to https://golang.org/src/cmd/internal/browser/browser.go that calls the right tool on each platform.

Otherwise, right now, on mac OS the tool works, but one can not open any file as there is no xdg-open binary.

peerdavid commented 4 years ago

Thanks for your comment and the very useful link. I want to test windows as well but I don't have mac OS. I will implement it accordingly to the link posted above (without testing) for mac OS and comment it here when the implementation is published.

AaronDavidSchneider commented 4 years ago

It seems that remapy crashs OSX. I just installed remapy on my mac using the install.sh file and launched it using the launch.sh. Next thing that happens is that my mac logs out and I need to log in back. Maybe just add a small warning to your readme.

peerdavid commented 4 years ago

It seems that remapy crashs OSX. I just installed remapy on my mac using the install.sh file and launched it using the launch.sh. Next thing that happens is that my mac logs out and I need to log in back. Maybe just add a small warning to your readme.

Thank you for this important information, I added a comment to the Readme.

peerdavid commented 4 years ago

This should now be fixed...

MeltedMagic commented 3 years ago

For those that still have an issue with xdg-open, change 'xdg-open' to 'open' in remapy/gui/file_explorer.py