peerdavid / remapy

An open source explorer for your remarkable tablet to show, upload or delete files via the remarkable cloud.
Apache License 2.0
174 stars 19 forks source link

Problems syncing with Remarkable Version 2.11 and colours #54

Closed Konrad982 closed 2 years ago

Konrad982 commented 2 years ago

The Remarkable version 2.11 software update introduces colours. Documents with colours fail to sync.

peerdavid commented 2 years ago

Thanks for the bug report. Unfortunately, not enough information is provided to fix the bug as my own device is not updated yet.

Konrad982 commented 2 years ago

What information would you need? I attach some screenshots to show you all the stroke options available for each type of pen after the update.

Information on the screenshots: Screenshots are made with https://github.com/bordaigorl/rmview after applying the fix https://github.com/bordaigorl/rmview/issues/117 in order to make colours visible as colours. On the remarkable itself, colours are displayed as shades of grey. I thought it may be helpful to know that rmview can in principle deal with colours.

EDIT: One screenshot is enough

rm-screenshot2

Konrad982 commented 2 years ago

UPDATE: Adding some dummy entries to the default_stroke_color dictionary in render.py prevents the sync from failing. However, it does not get the colors right yet. I think I might be able to solve that myself and add a pull request in the next days. default_stroke_color = { 0: (0 / 255., 0 / 255., 0 / 255.), # Pen color 1 1: (100 / 255., 100 / 255., 100 / 255.), # Pen color 2 2: (255 / 255., 255 / 255., 255 / 255.), # Eraser 3: (255 / 255., 255 / 255., 0), # Highlighter 4: (50 / 255., 50 / 255., 50 / 255.), # Pencil 5: (50 / 255., 50 / 255., 255 / 255.), 6: (50 / 255., 50 / 255., 255 / 255.), 7: (255 / 255., 50 / 255., 50 / 255.), 8: (50 / 255., 50 / 255., 50 / 255.), 9: (50 / 255., 50 / 255., 50 / 255.), 10: (50 / 255., 50 / 255., 50 / 255.), 11: (50 / 255., 50 / 255., 50 / 255.), 12: (50 / 255., 50 / 255., 50 / 255.), 13: (50 / 255., 50 / 255., 50 / 255.) }

peerdavid commented 2 years ago

Wow thank you so much for debugging and fixing - you are totally correct to add default stroke colors. Now we have to find the correct RGB values. In past, I simply used blue instead of black, but probably its better now to also adjust pen color 1 :)

Konrad982 commented 2 years ago

I just added a pull request that adds the colors and also renders highlighters first.

peerdavid commented 2 years ago

Should be solved now.